Skip to content

Meteora dbc fees included#8525

Closed
sandeshsk12 wants to merge 13 commits intoduneanalytics:mainfrom
sandeshsk12:meteora_dbc_fees_included
Closed

Meteora dbc fees included#8525
sandeshsk12 wants to merge 13 commits intoduneanalytics:mainfrom
sandeshsk12:meteora_dbc_fees_included

Conversation

@sandeshsk12
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

This is a test PR to see if adding new attributes will break the model


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: solana covers the Solana dbt subproject labels Jul 23, 2025
@dune-eng
Copy link

Workflow run id 16469759338 approved.

@dune-eng
Copy link

Workflow run id 16469759333 approved.

@dune-eng
Copy link

Workflow run id 16469759838 approved.

@dune-eng
Copy link

Workflow run id 16469763296 approved.

@dune-eng
Copy link

Workflow run id 16469763279 approved.

@dune-eng
Copy link

Workflow run id 16469763837 approved.

@dune-eng
Copy link

Workflow run id 16470003726 approved.

@dune-eng
Copy link

Workflow run id 16470003728 approved.

@dune-eng
Copy link

Workflow run id 16470004295 approved.

@dune-eng
Copy link

Workflow run id 16470256704 approved.

@dune-eng
Copy link

Workflow run id 16470256693 approved.

@dune-eng
Copy link

Workflow run id 16470257150 approved.

@krishgka
Copy link
Contributor

krishgka commented Aug 6, 2025

For fees is there any reason for working on this in dex trades?
Gas fees are not covered here in dex trades - normally we work on this in the respective gas fees project instead

@sandeshsk12
Copy link
Contributor Author

Hey @krishgka , this isn't gas fees, but swap fees. The fees charged by meteora (and not by solana). I am a bit busy right now, so not working on this actively. And this is not a pressing issue so can ignore this for now.

@krishgka
Copy link
Contributor

krishgka commented Aug 6, 2025

Thanks for bringing that up, normally for swap fees we account for them via fee_tier in the base trades file itself so you should add the fee calculation to the fee_tier field in the respective base trades model, not in the dex_solana_base_trades model. The main dex trades model is to handle generic aggregation and pricing

@jeff-dude jeff-dude closed this Jan 13, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: solana covers the Solana dbt subproject WIP work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants