Skip to content

paraswap: exclude base chain v6 due to incorrect amounts #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

jeff-dude
Copy link
Member

we got an alert in prod for amount_usd inflated to irregular amounts. it came down to one tx in paraswap v6 on base chain.

select *
from dex_aggregator.trades
where project = 'paraswap'
and version = '6'
and blockchain = 'base'
and tx_hash = 0xd649a110dbfb69350d0b87f25022a767c6bf77976cc2d235fcd8eb2cf1b9419b

https://basescan.org/tx/0xd649a110dbfb69350d0b87f25022a767c6bf77976cc2d235fcd8eb2cf1b9419b

this tx appears to be assigning the same raw amount to both token bought and sold, when it should not be. this leads to incorrect amount_usd amounts which affect the overall table.

we need to exclude until the bug is resolved. this likely goes back to the macro which decodes traces, which would then affect all chains, and this tx just happened to uncover it?

fyi @alexshchur

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jul 23, 2025
@jeff-dude jeff-dude marked this pull request as ready for review July 23, 2025 19:32
@Copilot Copilot AI review requested due to automatic review settings July 23, 2025 19:32
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jul 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily excludes ParaSwap v6 trades on the Base blockchain due to a data quality issue where transaction amounts are being incorrectly calculated, leading to inflated USD values that affect the overall aggregated trades table.

  • Removes paraswap_v6_base_trades from the model list to exclude problematic data
  • Adds explanatory comment documenting the exclusion reason
  • Maintains data integrity while the underlying amount calculation bug is being resolved

@jeff-dude jeff-dude self-assigned this Jul 23, 2025
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jul 23, 2025
@jeff-dude jeff-dude merged commit 83d06dd into main Jul 23, 2025
5 checks passed
@jeff-dude jeff-dude deleted the exclude-trouble-model branch July 23, 2025 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant