Skip to content

Conversation

@tomfutago
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Dec 15, 2025
@tomfutago tomfutago marked this pull request as ready for review December 17, 2025 13:38
@cursor
Copy link

cursor bot commented Dec 17, 2025

PR Summary

Adds xlayer Uniswap v2/v3 DEX base trades with sources, tests, seeds, and inclusion in the global dex.base_trades union.

  • DEX trades (xlayer):
    • Model: New incremental dex_xlayer.base_trades unioning uniswap_v2_xlayer_base_trades and uniswap_v3_xlayer_base_trades; casts amounts, filters non-negative, adds tx columns, and de-duplicates by tx_hash/evt_index.
    • Platforms: Add uniswap_v2_xlayer_base_trades and uniswap_v3_xlayer_base_trades using uniswap_compatible_v2_trades/uniswap_compatible_v3_trades macros.
    • Schema/Tests: Add _schema.yml with column checks, uniqueness tests, and seed validations (v2/v3 filters).
    • Sources: Define uniswap_v2_xlayer and uniswap_v3_xlayer event tables in sources/_sector/dex/trades/xlayer/_sources.yml.
    • Seeds: Add uniswap_xlayer_base_trades_seed (schema + CSV placeholder).
  • Global union:
    • Include ref('dex_xlayer_base_trades') in dbt_subprojects/dex/models/trades/dex_base_trades.sql.

Written by Cursor Bugbot for commit e3cdafd. Configure here.

@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 17, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

@tomfutago
Copy link
Contributor Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Comment @cursor review or bugbot run to trigger another review on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbt: dex covers the DEX dbt subproject ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant