Skip to content

Conversation

@tomfutago
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot added the WIP work in progress label Dec 16, 2025
@tomfutago tomfutago marked this pull request as ready for review December 16, 2025 13:16
@cursor
Copy link

cursor bot commented Dec 16, 2025

PR Summary

Introduces a Cursor IDE setup with catalyst command docs, Dune/AMP helper scripts, conventions, and ignore rules to streamline chain onboarding.

  • Tooling/IDE:
    • Add .cursor/ setup with README, command invocations, and project-specific conventions in rules/catalyst.md.
  • Commands/Docs:
    • New catalyst guides: foundational-metadata.md, gas-and-transfers.md, dex-integration.md with step-by-step workflows and queries.
    • Shared workflow steps in commands/catalyst/_shared.md.
  • Scripts:
    • Add scripts/dune_query.py for running Dune queries and check_amp_support.py to validate AMP metadata API support; include scripts README.md and pyproject.toml.
  • Ignore/Config:
    • Add .cursorignore; update .gitignore to track Cursor content while excluding generated artifacts/venvs.

Written by Cursor Bugbot for commit 73090f7. Configure here.

@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 16, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

if args.query_id is not None:
results = run_query(query_id=args.query_id, parameters=parameters if parameters else None)
else:
results = run_query(query=args.query)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Parameters silently ignored when using raw SQL query

The CLI accepts --param arguments regardless of whether --query-id or --query is used, but when --query (raw SQL) is specified, the parsed parameters are never passed to run_query. On line 122, the call run_query(query=args.query) omits the parameters argument entirely, while line 120 correctly passes them for --query-id. This means if a user runs something like dune_query.py --query "SELECT..." --param chain=ethereum, the parameter is parsed but silently discarded, leading to unexpected behavior without any warning.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants