-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CUR2-803: catalyst cursor enablement #9134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR SummaryIntroduces a Cursor IDE setup with catalyst command docs, Dune/AMP helper scripts, conventions, and ignore rules to streamline chain onboarding.
Written by Cursor Bugbot for commit 73090f7. Configure here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
| if args.query_id is not None: | ||
| results = run_query(query_id=args.query_id, parameters=parameters if parameters else None) | ||
| else: | ||
| results = run_query(query=args.query) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Parameters silently ignored when using raw SQL query
The CLI accepts --param arguments regardless of whether --query-id or --query is used, but when --query (raw SQL) is specified, the parsed parameters are never passed to run_query. On line 122, the call run_query(query=args.query) omits the parameters argument entirely, while line 120 correctly passes them for --query-id. This means if a user runs something like dune_query.py --query "SELECT..." --param chain=ethereum, the parameter is parsed but silently discarded, leading to unexpected behavior without any warning.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: