-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ft: add kyberswap_aggregator_trades for more chains #9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
PR SummaryExpands KyberSwap aggregator coverage and integrates new chains into the unified trades table.
Written by Cursor Bugbot for commit d8c2efe. Configure here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
| - name: kyberswap_aggregator_trades | ||
| meta: | ||
| blockchain: avalanche_c, optimism, ethereum, arbitrum, bnb, polygon, base | ||
| blockchain: avalanche_c, base, berachain, bnb, ethereum, linea, mantle, optimism, polygon, ronin, sonic, unichain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arbitrum blockchain missing from metadata and expose_spells
Medium Severity
The arbitrum blockchain was accidentally dropped from the metadata when adding new chains. The blockchain: field in _schema.yml and the expose_spells list in kyberswap_aggregator_trades.sql no longer include arbitrum, but the SQL model still references kyberswap_aggregator_arbitrum_trades in the models array. This creates an inconsistency where arbitrum data is included in the union query but not exposed in the spell metadata, potentially affecting downstream consumers and documentation that rely on these declarations.
Description:
add kyberswap_aggregator_trades for: berachain, linea, mantle, ronin, sonic, unichain