Skip to content

Conversation

@henrystats
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 13, 2026
@henrystats henrystats changed the title Refresh uniswapx trades Fix uniswapx trades Jan 13, 2026
@henrystats henrystats marked this pull request as ready for review January 13, 2026 15:48
@cursor
Copy link

cursor bot commented Jan 13, 2026

PR Summary

Refactors UniswapX trades to improve correctness and modeling clarity.

  • Introduces enriched, incremental uniswapx_trades per chain: uniswap_arbitrum_uniswapx_trades, uniswap_base_uniswapx_trades, uniswap_ethereum_uniswapx_trades, uniswap_unichain_uniswapx_trades (all using enrich_dex_trades over respective *_uniswapx_base_trades)
  • Replaces uniswap.uniswapx_trades with a view that unions the per-chain models and updates expose_spells to project-level "uniswap"
  • Removes deprecated uniswap_uniswapx_base_trades.sql union
  • Updates schema configs/metadata and adds/aligns uniqueness tests to include block_month for uniswap_uniswapx_trades and per-chain counterparts

Written by Cursor Bugbot for commit 951894f. Configure here.

@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbt: dex covers the DEX dbt subproject ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant