Skip to content

Conversation

@d-sonuga
Copy link
Contributor

@d-sonuga d-sonuga commented Feb 3, 2025

No description provided.

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (4b1b666) to head (920cb36).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          57       57           
  Lines        3781     3781           
=======================================
  Hits         3235     3235           
  Misses        546      546           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b1b666...920cb36. Read the comment docs.

Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it the new version?
And why it's marked as breaking?

@Neotamandua Neotamandua requested a review from xevisalle February 3, 2025 12:46
Copy link
Member

@xevisalle xevisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on this PR: #843

It's not a breaking change but will need a release after merge, can we coordinate so that we just need to release once?

@d-sonuga d-sonuga changed the title Update dusk-bls12_381 dependency to version 0.14 Update dependencies dusk-bls12_381 to version 0.14 and dusk-jubjub to 0.15 Feb 6, 2025
@d-sonuga d-sonuga merged commit bb56f00 into master Feb 6, 2025
11 checks passed
@d-sonuga d-sonuga deleted the bump-dusk-bls-dep branch February 6, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants