Skip to content

Conversation

@Neotamandua
Copy link
Member

@Neotamandua Neotamandua commented Nov 6, 2025

Update the toolchain to match version 1.82 used in other repositories and resolve recent CI failures.

Edit: Update to 1.84 due to #![feature(unsafe_extern_blocks)] problems that made the CI still fail.

CI failure reference: #854

@Neotamandua Neotamandua force-pushed the neotamandua/update_rustc branch 2 times, most recently from dff09ab to 13a0cdb Compare November 6, 2025 14:49
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.04%. Comparing base (2d4125a) to head (590bd14).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   85.55%   85.04%   -0.52%     
==========================================
  Files          57       57              
  Lines        3781     3617     -164     
==========================================
- Hits         3235     3076     -159     
+ Misses        546      541       -5     

see 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4125a...590bd14. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Neotamandua Neotamandua force-pushed the neotamandua/update_rustc branch from 13a0cdb to 590bd14 Compare November 6, 2025 14:54
@Neotamandua Neotamandua changed the title Update rust toolchain to nightly 2024-07-30 (1.82.0) Update rust toolchain to nightly 2024-10-17 (1.84.0) Nov 6, 2025
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neotamandua Neotamandua merged commit b25c18e into master Nov 6, 2025
11 checks passed
@Neotamandua Neotamandua deleted the neotamandua/update_rustc branch November 6, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants