Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groupify v1.0.0: Better STI/polymorphism and various fixes #61

Open
wants to merge 206 commits into
base: master
Choose a base branch
from
Open

Groupify v1.0.0: Better STI/polymorphism and various fixes #61

wants to merge 206 commits into from

Commits on Jun 30, 2017

  1. Add the ability to specify a map of association names to class names

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    00c923c View commit details
    Browse the repository at this point in the history

  2. Introduce has_member with :class_name option for custom class on … 

    …association
    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    87fadf5 View commit details
    Browse the repository at this point in the history

  3. Make it easier to add subclassed group associations with STI

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    c7d3e64 View commit details
    Browse the repository at this point in the history

  4. Updated docs for has_group

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    46e6ad8 View commit details
    Browse the repository at this point in the history

  5. Override << on collections to properly add membership_type

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    7696974 View commit details
    Browse the repository at this point in the history

  6. Add member to members collection rather than the group to groups coll… 

    …ection for polymorphic groups compatibility
    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    7dcaa1a View commit details
    Browse the repository at this point in the history

  7. Don't set default, for backwards-compatibility

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    f177d85 View commit details
    Browse the repository at this point in the history

  8. Query based group class (to support subclasses)

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    4bcff73 View commit details
    Browse the repository at this point in the history

  9. Remove unused option

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    337f3c9 View commit details
    Browse the repository at this point in the history

  10. Clear association cache after deleting associated models

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    1710727 View commit details
    Browse the repository at this point in the history

  11. Fix query to be extensible

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    3df2ea4 View commit details
    Browse the repository at this point in the history

  12. Refactored to mimic << method returning false if an invalid argum… 

    …ent is given otherwise returns collection
    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    2a84b72 View commit details
    Browse the repository at this point in the history

  13. Add to collection with options (e.g. membership type)

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    c9b8d58 View commit details
    Browse the repository at this point in the history

  14. Specify group class name when merging in case it's a subclass

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    ae7bec1 View commit details
    Browse the repository at this point in the history

  15. Remove group_type based on group class because we handle STI separa… 

    …tely
    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    0166f5d View commit details
    Browse the repository at this point in the history

  16. Use ActiveRecord base_class in case member is STI

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    b87d1f1 View commit details
    Browse the repository at this point in the history

  17. Revert back to using association and assume STI

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    74b3044 View commit details
    Browse the repository at this point in the history

  18. Added ability for group.add to throw a validation exception

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    abd27e4 View commit details
    Browse the repository at this point in the history

  19. Remove unneeded default_members_association_name feature

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    76d45cc View commit details
    Browse the repository at this point in the history

  20. Don't use validate! to ensure Rails 4.0.x compatibility

    @joelvh
    joelvh committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    5694c15 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2017

  1. Move extensions modules to separate files

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    c18a2f4 View commit details
    Browse the repository at this point in the history

  2. Consolidate queries for deleting records

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    ef466f2 View commit details
    Browse the repository at this point in the history

  3. Refactor to handle groups and members associations with same logic

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    de70b89 View commit details
    Browse the repository at this point in the history

  4. Moved delete and destroy methods to shared module

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    f4ef818 View commit details
    Browse the repository at this point in the history

  5. Move finder methods to appropriate modules

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    16a5896 View commit details
    Browse the repository at this point in the history

  6. Reuse delete/destroy logic

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    fcaf155 View commit details
    Browse the repository at this point in the history

  7. Require modules

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    34d659b View commit details
    Browse the repository at this point in the history

  8. Mark methods protected

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    3eb9a59 View commit details
    Browse the repository at this point in the history

  9. Define add explicitly as raising an exception instead of using opts

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    a5b73cf View commit details
    Browse the repository at this point in the history

  10. Alias add and << in shared module

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    4ec1ae1 View commit details
    Browse the repository at this point in the history

  11. Simplify abstractions and fix some reference errors

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    8f64968 View commit details
    Browse the repository at this point in the history

  12. Fixed alias methods

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    3fd5074 View commit details
    Browse the repository at this point in the history

  13. Fix super reference

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    19f76bb View commit details
    Browse the repository at this point in the history

  14. Added group_type to query to properly build membership record

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    c52d063 View commit details
    Browse the repository at this point in the history

  15. Added tests to make sure inverse associations are updated after `dele… 

    …te` and `destroy`
    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    539b97c View commit details
    Browse the repository at this point in the history

  16. Added tests to make sure members and groups aren't added more than once

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    aa82ec4 View commit details
    Browse the repository at this point in the history

  17. Added tests to check subclassing

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    31bcafe View commit details
    Browse the repository at this point in the history

  18. Fix whitespace

    @joelvh
    joelvh committed Jul 1, 2017
    Configuration menu
    Copy the full SHA
    a3935e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2017

  1. Use merge instead of where

    @joelvh
    joelvh committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    eea48e0 View commit details
    Browse the repository at this point in the history

  2. Refactor where with merge

    @joelvh
    joelvh committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    adf691d View commit details
    Browse the repository at this point in the history

  3. Let Rails generate the queries on group_id and group_type

    @joelvh
    joelvh committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    3dfd19e View commit details
    Browse the repository at this point in the history

  4. Update group_type for completeness

    @joelvh
    joelvh committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    341eae1 View commit details
    Browse the repository at this point in the history

  5. Remove commented code

    @joelvh
    joelvh committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    2e87738 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2017

  1. Remove duplicated extension modules from rebase

    @joelvh
    joelvh committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    52517a3 View commit details
    Browse the repository at this point in the history

  2. Simplify member criteria

    @joelvh
    joelvh committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    972b80d View commit details
    Browse the repository at this point in the history

  3. helpers to query on polymorphic groups and members

    @joelvh
    joelvh committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    f213396 View commit details
    Browse the repository at this point in the history

  4. Use merge and helpers for query

    @joelvh
    joelvh committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    1734420 View commit details
    Browse the repository at this point in the history

  5. clearer logic

    @joelvh
    joelvh committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    68e9028 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2017

  1. Add ability to call has_group :custom_groups, "CustomGroup"

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    04c6cf3 View commit details
    Browse the repository at this point in the history

  2. Clarify logic and simplify some steps

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    7d321d3 View commit details
    Browse the repository at this point in the history

  3. Pass each record as separate parameter

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    31f2afe View commit details
    Browse the repository at this point in the history

  4. Include type column when counting matches

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    c6bd4cd View commit details
    Browse the repository at this point in the history

  5. Removed unused method

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    0a05de7 View commit details
    Browse the repository at this point in the history

  6. Added helper method to make it easier to read SQL criteria

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    c5db985 View commit details
    Browse the repository at this point in the history

  7. DRY logic

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    77c438e View commit details
    Browse the repository at this point in the history

  8. Simplify logic when finding matching named group

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    efe9df9 View commit details
    Browse the repository at this point in the history

  9. Simplify variable use

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    b990b0f View commit details
    Browse the repository at this point in the history

  10. Simplify membership query building

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    d5af10b View commit details
    Browse the repository at this point in the history

  11. Code spacing

    @joelvh
    joelvh committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    98fb5a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2017

  1. Refer to arel_table consistently

    @joelvh
    joelvh committed Jul 9, 2017
    Configuration menu
    Copy the full SHA
    3440327 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2017

  1. Removed unused methods

    @joelvh
    joelvh committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    6c5c226 View commit details
    Browse the repository at this point in the history

  2. Formatted for clarity

    @joelvh
    joelvh committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    3b0f9a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2017

  1. Consolidate association extensions and move helpers to ActiveRecord… 

    … module
    @joelvh
    joelvh committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    922c102 View commit details
    Browse the repository at this point in the history

  2. Fix polymorphic adding of members to groups by bypassing association … 

    …reference
    @joelvh
    joelvh committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    9ed5007 View commit details
    Browse the repository at this point in the history

  3. Added memberships_merge helper to named groups

    @joelvh
    joelvh committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    1f82fda View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2017

  1. Add helper method to infer class and association names

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    f9d3216 View commit details
    Browse the repository at this point in the history

  2. Clean up membership_type usage and check presence better/minimally

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    00fe96b View commit details
    Browse the repository at this point in the history

  3. Improve inferring parent model when model can be group and member

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    19f73cb View commit details
    Browse the repository at this point in the history

  4. Consolidate membership_merge logic

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    8295cbd View commit details
    Browse the repository at this point in the history

  5. Exclude ActiveRecord::AssociationTypeMismatch test because it is no… 

    …t raised with polymorphic logic
    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    f32e082 View commit details
    Browse the repository at this point in the history

  6. Build query via chain instead of control logic

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    64fecca View commit details
    Browse the repository at this point in the history

  7. Set blank values to nil

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    3dbe428 View commit details
    Browse the repository at this point in the history

  8. Throw "type mismatch" exception when adding to association

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    4192d31 View commit details
    Browse the repository at this point in the history

  9. Update Mongoid with some similar code cleanup as ActiveRecord

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    eea79b3 View commit details
    Browse the repository at this point in the history

  10. Fixed filter fallback in tests

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    856377f View commit details
    Browse the repository at this point in the history

  11. Fix flattening arrays

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    f708dba View commit details
    Browse the repository at this point in the history

  12. DRY up Mongoid similar to ActiveRecord

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    a47b625 View commit details
    Browse the repository at this point in the history

  13. Fix Mongoid test

    @joelvh
    joelvh committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    e2cf3e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2017

  1. Rails 4.0 doesn't like merging empty hash, so we build the query step… 

    … by step
    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    3614e2a View commit details
    Browse the repository at this point in the history

  2. Fix test to use specific IDs

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    c7f09bd View commit details
    Browse the repository at this point in the history

  3. Clear association cache on child after creating membership

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    a3ba035 View commit details
    Browse the repository at this point in the history

  4. Fix tests for Postgres which changes the order of records

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    33f7af2 View commit details
    Browse the repository at this point in the history

  5. Fix tests to compare arrays properly

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    028f88c View commit details
    Browse the repository at this point in the history

  6. Simplify methods by removing outdated aliasing

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    df9bdb8 View commit details
    Browse the repository at this point in the history

  7. Add test to make sure associations are reset after deletion

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    228aa6c View commit details
    Browse the repository at this point in the history

  8. Add defaultmembers association in more intuitive spot

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    f47a514 View commit details
    Browse the repository at this point in the history

  9. Fix named group support in Rails 5 

    Rails 5 made `belongs_to` associations required by default. When using named groups, the group association is expected to be empty. This fixes the issue in a Rails 4 compatible way by adding `required: false`

Fixes dwbutler#65
    @dwbutler
    dwbutler committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    e3240ab View commit details
    Browse the repository at this point in the history

  10. Clean up has_member and has_group and allow association options

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    cfbbc8f View commit details
    Browse the repository at this point in the history

  11. Fix wrong variable name reference

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    49f592d View commit details
    Browse the repository at this point in the history

  12. Add has_groups and has_group to Mongoid

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    8271701 View commit details
    Browse the repository at this point in the history

  13. Add proper default class

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    ed43370 View commit details
    Browse the repository at this point in the history

  14. Only look up base class if needed

    @joelvh
    joelvh committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    3f051c8 View commit details
    Browse the repository at this point in the history

  15. Fix Rails 4.0 - 4.1, which don't support the required option 

    Also, specs for models that are only named group members, and don't use groups
    @dwbutler
    dwbutler committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    5781d41 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2017

  1. Added Groupify.ignore_base_class_inference_errors to swallow infere… 

    …nce errors with `base_class`
    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    7dc1405 View commit details
    Browse the repository at this point in the history

  2. Use source_type instead of class_name

    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    50bdc00 View commit details
    Browse the repository at this point in the history

  3. Consolidate has_member and has_group and add error handling

    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    3f69372 View commit details
    Browse the repository at this point in the history

  4. Use base class

    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    31ed051 View commit details
    Browse the repository at this point in the history

  5. Update tests with autoload to help resolve circular class dependencies

    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    e4b0fdd View commit details
    Browse the repository at this point in the history

  6. Moved test classes to separate files for autoloading

    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    92f08fb View commit details
    Browse the repository at this point in the history

  7. Indicate value of variable better in exception (e.g. when nil)

    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    38bdff0 View commit details
    Browse the repository at this point in the history

  8. Simplify

    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    fd36319 View commit details
    Browse the repository at this point in the history

  9. Add option to return a string version of inferred class name rather t… 

    …han trying to constantize
    @joelvh
    joelvh committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    691a28d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2017

  1. Fix variable name

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    a18bd85 View commit details
    Browse the repository at this point in the history

  2. Add class_name in case the default group class is a STI subclass

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    435e294 View commit details
    Browse the repository at this point in the history

  3. Use default group class when base class can't be resolved

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    2cf9875 View commit details
    Browse the repository at this point in the history

  4. Make default members and groups association names configurable

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    e056730 View commit details
    Browse the repository at this point in the history

  5. Abstract out extension methods

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    ae3ba76 View commit details
    Browse the repository at this point in the history

  6. Introduce PolymorphicChildren collection class to

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    cfd9b98 View commit details
    Browse the repository at this point in the history

  7. Disabled autoloading in tests (for now)

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    895b345 View commit details
    Browse the repository at this point in the history

  8. Remove unused argument

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    39bd88b View commit details
    Browse the repository at this point in the history

  9. Split out polymorphic classes for multiple uses

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    3e3acb0 View commit details
    Browse the repository at this point in the history

  10. Properly merge queries

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    bae0e02 View commit details
    Browse the repository at this point in the history

  11. Allow modifying query

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    788ef79 View commit details
    Browse the repository at this point in the history

  12. Crate a relation

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    d1ed8f6 View commit details
    Browse the repository at this point in the history

  13. Scope properly

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    b6485b6 View commit details
    Browse the repository at this point in the history

  14. Fix variable name

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    74c6b57 View commit details
    Browse the repository at this point in the history

  15. Fix query nesting

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    900ce84 View commit details
    Browse the repository at this point in the history

  16. Fix type

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    6196619 View commit details
    Browse the repository at this point in the history

  17. Add pretty_print

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    a43048f View commit details
    Browse the repository at this point in the history

  18. Rename block argument for consistency

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    f76d1b3 View commit details
    Browse the repository at this point in the history

  19. Use instance_eval for consistency

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    a895ea4 View commit details
    Browse the repository at this point in the history

  20. Fix up some consistency in the code

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    92f513b View commit details
    Browse the repository at this point in the history

  21. Remove duplicated class definitions

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    9fd75bd View commit details
    Browse the repository at this point in the history

  22. Fix postgres by changing from GROUP BY to DISTINCT ON

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    b59feaf View commit details
    Browse the repository at this point in the history

  23. Added test to make sure polymorphic groups are unique

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    a8a22f7 View commit details
    Browse the repository at this point in the history

  24. Make sure that count is correct based on PostgreSQL DISTINCT vs. GR… 

    …OUP BY
    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    7ca1813 View commit details
    Browse the repository at this point in the history

  25. Make sure memberships are added properly based on role

    @joelvh
    joelvh committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    d1686b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. Moved parent/child logic into ParentProxy class to consolidate and … 

    …simplify
    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    c592f93 View commit details
    Browse the repository at this point in the history

  2. Fix for group deletion deleting group membership after merge... not s… 

    …ure why this is happening now - no logic changes.
    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    09f1964 View commit details
    Browse the repository at this point in the history

  3. Simplify class

    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    09cadcb View commit details
    Browse the repository at this point in the history

  4. Move query logic to ParentQueryBuilder class

    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    083509e View commit details
    Browse the repository at this point in the history

  5. Clarify logic

    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    e0b7037 View commit details
    Browse the repository at this point in the history

  6. DRY up has_many creation

    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    57b46ea View commit details
    Browse the repository at this point in the history

  7. Rename "query" to "scope"

    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    3dd6891 View commit details
    Browse the repository at this point in the history

  8. determine child type

    @joelvh
    joelvh committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    679da0e View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2017

  1. Fix Rails 4.0-5.0 tests using extending on model class when chainin… 

    …g scopes
    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    96a588f View commit details
    Browse the repository at this point in the history

  2. Fix DISTINCT queries in PostgreSQL for SELECT vs COUNT

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    0d57f0a View commit details
    Browse the repository at this point in the history

  3. Drop support for Rails 4.0

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    039a94a View commit details
    Browse the repository at this point in the history

  4. Use helper to build query

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    1100d09 View commit details
    Browse the repository at this point in the history

  5. DRY up code with helpers

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    b0dbaa6 View commit details
    Browse the repository at this point in the history

  6. Make default member class configurable

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    ba6015d View commit details
    Browse the repository at this point in the history

  7. Fix merge to use all scope for Rails 4.0-5.0

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    f3b76b8 View commit details
    Browse the repository at this point in the history

  8. Make public method names more user friendly

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    f036617 View commit details
    Browse the repository at this point in the history

  9. Fix children_association parent reference

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    52c528d View commit details
    Browse the repository at this point in the history

  10. Add superclass helper to get inherited values for STI

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    273b78d View commit details
    Browse the repository at this point in the history

  11. Use inherited class and association names

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    2d8004a View commit details
    Browse the repository at this point in the history

  12. Standardize same options on group members as on groups

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    be3ddd4 View commit details
    Browse the repository at this point in the history

  13. DRY configuring defaults

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    1f1ecd7 View commit details
    Browse the repository at this point in the history

  14. Return nothing if child association name not specified

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    9d65209 View commit details
    Browse the repository at this point in the history

  15. Don't delegate methods to create records

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    2b82b3b View commit details
    Browse the repository at this point in the history

  16. Updated README with polymorphic and STI documentation

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    2310dd2 View commit details
    Browse the repository at this point in the history

  17. Added tests for disabling default associations

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    566e7ae View commit details
    Browse the repository at this point in the history

  18. Add block to extend has_many

    @joelvh
    joelvh committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    7b8ee8f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. Indicate 4.1+ support

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    5a3ade8 View commit details
    Browse the repository at this point in the history

  2. Updated README

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    1475205 View commit details
    Browse the repository at this point in the history

  3. Revert ActiveRecord configuration to inline for clarity

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    434b6e6 View commit details
    Browse the repository at this point in the history

  4. Replicated configuration setup from ActiveRecord to Mongoid

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    9ac8b4d View commit details
    Browse the repository at this point in the history

  5. Renamed "merge" methods for clarity

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    2ae566b View commit details
    Browse the repository at this point in the history

  6. Removed redundant scope merge

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    bee094f View commit details
    Browse the repository at this point in the history

  7. Disable appraisal gem because it causes segfaults - loosen other ge… 

    …m versions
    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    ca534e0 View commit details
    Browse the repository at this point in the history

  8. Don't add default associations by default, but provide `configure_leg… 

    …acy_defaults!` for backwards-compatibility
    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    a6d2a90 View commit details
    Browse the repository at this point in the history

  9. Updated README

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    003fe8f View commit details
    Browse the repository at this point in the history

  10. Consistent naming of opts

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    b72a143 View commit details
    Browse the repository at this point in the history

  11. Cleanup unused code

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    8909726 View commit details
    Browse the repository at this point in the history

  12. Update generator with default configuration comments

    @joelvh
    joelvh committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    d9305e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2017

  1. Note that groups and members need to be persisted first

    @joelvh
    joelvh committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    48ec17a View commit details
    Browse the repository at this point in the history

  2. Add method to get membership types for a group/member combo

    @joelvh
    joelvh committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    fb89783 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2017

  1. Add ParentQueryBuilder methods as extension methods to models

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    f302c0e View commit details
    Browse the repository at this point in the history

  2. Build extensions in separate files for clarity

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    8768892 View commit details
    Browse the repository at this point in the history

  3. Generate extension modules rather than using helper classes

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    10c370a View commit details
    Browse the repository at this point in the history

  4. Pass extension block to has_many

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    7fba336 View commit details
    Browse the repository at this point in the history

  5. Continued de-duplication of code with dynamic module creation

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    d95c594 View commit details
    Browse the repository at this point in the history

  6. Renamed ModelMembershipExtensions to ModelExtensions

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    3ef6176 View commit details
    Browse the repository at this point in the history

  7. Remove references to old classes

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    7b6bc9c View commit details
    Browse the repository at this point in the history

  8. Fix module naming

    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    7f54082 View commit details
    Browse the repository at this point in the history

  9. Added ability to search on multiple membership types (SQL OR/`IN(..… 

    ….)`) query
    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    ec14b70 View commit details
    Browse the repository at this point in the history

  10. Fix tests and DSL to allow both group and member implemented on one m… 

    …odel
    @joelvh
    joelvh committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    e30b732 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2017

  1. Set class_name when inferring class from association name (STI)

    @joelvh
    joelvh committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    61612d8 View commit details
    Browse the repository at this point in the history

  2. Removed Rails 4.1 support

    @joelvh
    joelvh committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    d7ab6fd View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary option

    @joelvh
    joelvh committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    0757a3a View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2017

  1. Fixes Rails 4.2 bug merging associations

    @joelvh
    joelvh committed Aug 19, 2017
    Configuration menu
    Copy the full SHA
    5f23bed View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2017

  1. Adding should throw validation exception because old version called `… 

    …create!`
    @joelvh
    joelvh committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    6e668c7 View commit details
    Browse the repository at this point in the history

  2. Fix tests to use specific order of records for PostgreSQL

    @joelvh
    joelvh committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    6a19ef0 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2017

  1. Fix merging relations that don't go through group memberships

    @joelvh
    joelvh committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    95c4ebb View commit details
    Browse the repository at this point in the history

  2. Fix test to order comparison for PostgreSQL

    @joelvh
    joelvh committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    3c020ca View commit details
    Browse the repository at this point in the history

  3. Remove db type check

    @joelvh
    joelvh committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    6469902 View commit details
    Browse the repository at this point in the history

  4. Use new helper method

    @joelvh
    joelvh committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    76b70c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2017

  1. Check for relation to generate subquery

    @joelvh
    joelvh committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    88c255a View commit details
    Browse the repository at this point in the history

  2. Fixed exclusion path

    @joelvh
    joelvh committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    cb5c741 View commit details
    Browse the repository at this point in the history

  3. Require newer versions of gems

    @joelvh
    joelvh committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    f64a844 View commit details
    Browse the repository at this point in the history

  4. Simplify generated variable names and clarify attribute references

    @joelvh
    joelvh committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    3f99967 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2017

  1. Fix test that is using a class that wasn't designated as a group member

    @joelvh
    joelvh committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    3696802 View commit details
    Browse the repository at this point in the history

  2. Fix inverse association references for unsaved records

    @joelvh
    joelvh committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    a46ff8e View commit details
    Browse the repository at this point in the history

  3. Test for persistence of new records when adding to groups

    @joelvh
    joelvh committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    a1edc01 View commit details
    Browse the repository at this point in the history

  4. Added brief descriptions to polymorphic classes

    @joelvh
    joelvh committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    cde2b17 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2017

  1. Fix MySQL GROUP BY error when sql_mode=only_full_group_by 

    Fixed error by removing GROUP BY all together because selecting the ID
column without being listed in the GROUP BY clause is not allowed in
MySQL when in “strict” mode.
    @joelvh
    joelvh committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    284df94 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Add instructions on how to run tests

    @joelvh
    joelvh committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    719430d View commit details
    Browse the repository at this point in the history

  2. Made further cross-database SQL compatibility fixes for DISTINCT

    @joelvh
    joelvh committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    97d3db6 View commit details
    Browse the repository at this point in the history

  3. Add line info for dynamic modules

    @joelvh
    joelvh committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    3831368 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'dwbutler/fix/rails5-named-groups' into … 

    …feature/polymorphic_adding
    @joelvh
    joelvh committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    3c7d529 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2017

  1. Clean membership handling - could add multiple memberships at once

    @joelvh
    joelvh committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    ad62271 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2017

  1. Update authors

    @joelvh
    joelvh committed Sep 10, 2017
    Configuration menu
    Copy the full SHA
    ff2c0e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. Fix attempt to join and merge to do so on group model, not group memb… 

    …ership
    @joelvh
    joelvh committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    3959b50 View commit details
    Browse the repository at this point in the history

  2. Join and merge is flawed - removed

    @joelvh
    joelvh committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    e9b7e62 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2017

  1. Clarify error source

    @joelvh
    joelvh committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    05035e0 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. Don't infer association or class name if :class_name option is spec… 

    …ified
    @joelvh
    joelvh committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    dea8e47 View commit details
    Browse the repository at this point in the history