tpr/24-sort-words #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonic
reviewed
Dec 25, 2017
dictmaker.js
Outdated
|
|
||
| console.log('processing word list...'); | ||
|
|
||
| var words = content.split('\n'); |
There was a problem hiding this comment.
var words does not appear to be used below ... 🤔
There was a problem hiding this comment.
Doh! That'll teach me to code on Xmas.
|
Hi, |
|
@MysticMight : I'd recommend doing that. It has been 2 months, it appears there's no rush to act on this PR. At this point, I wash my hands. Merge, fork, delete -- I don't care. Best of luck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I acted on doug719's advice and sorted
words.txtandwords_alpha.txtusing the unixsortcommand.Sorting the json file is trickier, so I wrote a JS script (I don't know Python) to generate it based on
words_alpha.txt; you are welcome to rewrite it in Python.I also updated all three zip files.