Skip to content

feat: Permissioned keys#322

Merged
v0-e merged 11 commits intomainfrom
ev/add-auth
Mar 5, 2025
Merged

feat: Permissioned keys#322
v0-e merged 11 commits intomainfrom
ev/add-auth

Conversation

@v0-e
Copy link
Contributor

@v0-e v0-e commented Feb 3, 2025

Permissionless key implementation.
Interface for the permissioning account is through NodeClient::authenticators() for gRPC requests.
Interface for the permissioned account is through Account::authenticators().

Closes #318.

Had to increase fee adjustment multiplier a bit (from 1.4 to 1.8). While the TS client has it at 1.6, some transactions were being rejected at this value here. Issue #320 may be related.

(edit: ready) Awaiting on a cosmrs release which fixes a small issue related with non-critical Tx extensions.

@v0-e v0-e changed the title Ev/add auth feat: Permissionless keys Feb 3, 2025
@v0-e v0-e changed the title feat: Permissionless keys feat: Permissioned keys Feb 3, 2025
@v0-e v0-e marked this pull request as ready for review February 10, 2025 11:27
@v0-e v0-e requested review from a team as code owners February 10, 2025 11:27
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have observed support for authenticator validation, but no tests appear to demonstrate its functionality.

@v0-e
Copy link
Contributor Author

v0-e commented Mar 5, 2025

Thanks @pnowosie :)
Authenticator validation tests are provided here.

@v0-e v0-e merged commit 1677a41 into main Mar 5, 2025
7 checks passed
v0-e added a commit that referenced this pull request Mar 5, 2025
Main change is the renaming of `rand` functions.
Bumps also `cosmrs` patch version to allow #322.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

permissionned keys on rust

2 participants