-
Notifications
You must be signed in to change notification settings - Fork 368
feat: kas bridge #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kas bridge #1883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
x/kas/keeper/keeper.go
Outdated
} | ||
|
||
func (k *Keeper) SetProcessedWithdrawal(ctx sdk.Context, withdrawal types.WithdrawalID) error { | ||
// see https://github.com/dymensionxyz/hyperlane-cosmos/blob/fb914a5ba702f70a428a475968b886891cb1ad77/x/core/keeper/logic_message.go#L50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u be more informative with the comment, beside the reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried my best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
Co-authored-by: Michael Tsitrin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 22.09% 21.78% -0.32%
==========================================
Files 601 619 +18
Lines 141821 146022 +4201
==========================================
+ Hits 31339 31808 +469
- Misses 105693 109356 +3663
- Partials 4789 4858 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
https://www.notion.so/dymension/ADR-Kaspa-Bridge-Theory-203a4a51f86a806bb7b3d08bada58297?v=2558aaa9b1724690b4fa752695f26eb7
https://www.notion.so/dymension/ADR-Kaspa-Bridge-Implementation-206a4a51f86a803980aec7099c826fb4
Please review sibiling PR dymensionxyz/hyperlane-cosmos#10 too!
Closes #1886
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
For Reviewer:
After reviewer approval: