feat: refactor W3C scenario to support multiple crypto algo settings #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is summing up quite some changes to W3C code but will make sure that all tests are passed, the only disruptive change so far is the It is unfinished since it still needs a rewrite of |
jaromil
force-pushed
the
feat/more_algos_sdjwt
branch
from
8d8b9c8 to
eb959e7
Compare
jaromil
changed the title
|
We have the transformation zencode keyring to jwks, maybe it can also be usefull to have jwks to zencode keyring/public key 🔐 Let me know if it something that you would like to add to this PR or I should make an issue |
matteo-cristino
force-pushed
the
feat/more_algos_sdjwt
branch
from
2a8f536 to
aab6c86
Compare
The statement: `create signed selective disclosure of '' with ''` is now added to specify a string with name of algo, which is parsed internally with uppercase strings of algos set in sd-jwt structures
when serializing r and s to verify the signature in ECDH, sometimes (non deterministically) the signature comes 63 bytes long and does not verify
also fix octet concat, since the milagro primitive seemed to break something
variable size is tolerated between 62 and 64 bytes for corner cases
supports verifying jws that carry a jwk with public keys in its header according to oauth dpop spec 4.2 DPoP Proof JWT Syntax
this new class will help resolve the many names given to each cryptographic algorithm and will take IANA as a main reference for them, with conversion from any string and to and from key names already used in zenroom
simplier to use and maintain, CRYPTO.load() is the main entry
moved de/serialization methods into JSON and jwk/jws into JOSE
jaromil
force-pushed
the
feat/more_algos_sdjwt
branch
from
fa56337 to
f222fc9
Compare
add also export of the d field
… header contains more fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statement:
create signed selective disclosure of '' with ''is now added to specify a string with name of algo, which is parsed internally with uppercase strings of algos set in sd-jwt structures