Skip to content

fix: update merkle tree #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

fix: update merkle tree #1065

wants to merge 30 commits into from

Conversation

matteo-cristino
Copy link
Collaborator

  • added a function for test vectors in merkle_tree.lua, created tests for creation merkle tree check_merkle_tree.lua
  • chore(style): remove trailing whitespaces

@matteo-cristino matteo-cristino mentioned this pull request May 7, 2025
Closed
@jaromil
Copy link
Member

jaromil commented May 7, 2025

very well, there is no fix: commit so I'll wait for merge in case we want to trigger release

@matteo-cristino matteo-cristino marked this pull request as draft May 7, 2025 08:52
@matteo-cristino
Copy link
Collaborator Author

matteo-cristino commented May 7, 2025 •
edited
Loading

TODO:

  • ✅ add merkle vector test to run with all other test (add it to bats file in vector test)
  • ✅ vector tests do not work beacuse function called are local in zencode_merkletree.lua, maybe create crypto_merkletree.lua as we did for the other packages?
  • ✅ vector test call a non existing data2 dictioanry

@matteo-cristino
Copy link
Collaborator Author

matteo-cristino commented May 7, 2025 •
edited
Loading

✅ bonus point: maybe _create_merkle_tree can be optimized, I'm not sure if the first for loop where all the tree is set to 0 string is really needed 🔮

@matteo-cristino matteo-cristino marked this pull request as ready for review May 8, 2025 07:50
@matteo-cristino matteo-cristino marked this pull request as draft May 8, 2025 10:17
matteo-cristino
matteo-cristino commented May 30, 2025
View reviewed changes
matteo-cristino
matteo-cristino commented Jun 3, 2025
View reviewed changes
@matteo-cristino matteo-cristino marked this pull request as ready for review June 6, 2025 08:02
nsuzzi and others added 18 commits June 24, 2025 11:28
@nsuzzi @jaromil
added a function for test vectors in merkle_tree.lua, created tests f…
04d7871 
…or creation merkle tree check_merkle_tree.lua
@matteo-cristino @jaromil
chore(style): remove trailing whitespaces
e0e5a5d
@nsuzzi @jaromil
correct errors in check_merkle_tree.lua, create test vectors merkletr…
ef872ce 
…ee.bats
@matteo-cristino @jaromil
fix(merkle_tree): move crypto function to crypto_merkle.lua
d426522 
small improvements to creation of merkle tree and error messages
@matteo-cristino @jaromil
test(merkle_tree): update vector tests to use crypto_merkle.lua
83dd653
@matteo-cristino @jaromil
fix: merkle_tree contains root in position one
dede70a 
the shift done in source code (that used 0-based indexing) seems only used to simplify math operations, so here we can directly start from beginning of array (1-based indexing)
@nsuzzi @jaromil
function that generate a proof for a merkle tree given the position o…
1f78edb 
…f a leaf and the correspodig function that verify it
@nsuzzi @jaromil
create a function that will help in the generation of a compressed pr…
2a80a0a 
…oof for a merkle tree
@nsuzzi @jaromil
modified verifier function for merkle tree, added a function for calc…
4e8561f 
…ulate the lenght of a merkle tree and finished test for MT.verify_proof from frigo's code
@nsuzzi @jaromil
added function for creating a compressed merkle proof and its respect…
c2d24e4 
…ive verify function, added test vector from frigo's RFC
@nsuzzi @jaromil
modified MT.verify_compressed proof, added a function for a random se…
8564062 
…tting of the test for merkle tree, added test for MT.verify_compressed_proof from Frigo's code
@nsuzzi @jaromil
added a test for the case having an empty proof from Frigo's code
07a24f2
@nsuzzi @jaromil
just removed some 'local' ahead some function
7b43644
@nsuzzi @jaromil
fixed errors in crypto_merkle and check_merkle_tree
72fc35c
@nsuzzi @jaromil
fixed errors in vectors/ check_merkle_tree
31ecfb1
@matteo-cristino @jaromil
test: fix merkle tree tests
912f103
@matteo-cristino @jaromil
chore: increase timeout limit for vector tests
d459ab3
@nsuzzi @jaromil
added sources of the written code
0aca309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteo-cristino @jaromil @nsuzzi