-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enrollment preprocessing CLI tool #2011
Conversation
15021a3
to
09d6bf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More in-depth this time, so a few more comments, but it's all very detail-y.
I were ably to combine initial excel parsing and conflict grouping, because of direct conversion from Cells to Users, but the update logic needed more complexity (Codacy is not very happy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed: The tool asks for the same user multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work now
Just to be sure: Currently the whole userdata from the conflict is shown, so this question is possible:
Selecting imported only applies the conflicting field, here the first name (resulting data: Lucilia Prorsus, [email protected])
is asked instead. |
We can leave that as it is now. I'd say the second way makes interpretation harder. |
fix #1490
Upload my progress on the cli tool from monday.