-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test new error handling indicating when the sandbox is not found #540
Open
0div
wants to merge
21
commits into
main
Choose a base branch
from
return-error-indicating-that-the-sandbox-is-not-running-when-e2b-1327-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−23
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
37855b9
add host test for sandbox not found error
0div 91770ae
skip to not block wokflow
0div 55ecbaf
Update packages/js-sdk/tests/sandbox/host.test.ts
0div c00f73f
skip ifdebug
0div c96e4de
merge upstream
0div ad3d8fb
skip ifdebug
0div a9c283e
edits based on feedback
0div 399f929
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div 7cc525e
Merge branch 'main' of https://github.com/e2b-dev/E2B into return-err…
0div 06ef257
address PR comments
0div cb0a3a0
Merge branch 'main' of https://github.com/e2b-dev/E2B into return-err…
0div a7606f5
Apply suggestions from code review
jakubno 3ecbc9f
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div 21858ad
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div febf55a
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div f5cde50
fix type in host test
0div 4540c86
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div 1823bd7
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div c16bb4d
fixe merge conflict with main
0div 7923032
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div 62b4a47
Merge branch 'main' into return-error-indicating-that-the-sandbox-is-…
0div File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply suggestions from code review
commit a7606f5d8024d7e20564efc28cca2e2aeda6f597
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the port would be better in a constant