Skip to content

Add image URI mask option for template build to allow custom image repository #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

sitole
Copy link
Member

@sitole sitole commented Jul 15, 2025

This will allow customers who are not using our Docker repository to fall back to their own during template build.

@sitole sitole self-assigned this Jul 15, 2025
Copy link

changeset-bot bot commented Jul 15, 2025

🦋 Changeset detected

Latest commit: f289b4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@e2b/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sitole
Copy link
Member Author

sitole commented Jul 17, 2025

I will be used as follows:

e2b template build --image-url-mask=0123456789.dkr.ecr.eu-west-1.amazonaws.com/custom-environments:{buildID}

@sitole sitole marked this pull request as ready for review July 17, 2025 11:23
@sitole sitole requested a review from dobrac July 17, 2025 11:24
@mishushakov
Copy link
Member

Okay, I think it's the name that was confusing me - can you maybe change it to

--image-uri

@sitole
Copy link
Member Author

sitole commented Jul 17, 2025

Okay, I think it's the name that was confusing me - can you maybe change it to

--image-uri

I think mask in the name is very important. There is a variable in it that is resolved during runtime

@sitole sitole force-pushed the template-build-image-url-mask branch from 7312955 to f56eee6 Compare July 17, 2025 13:25
@sitole sitole added the feature New feature or request label Jul 18, 2025
@sitole sitole changed the title Add --image-url-mask option for template build to allow custom image repository Add image URI mask option for template build to allow custom image repository Jul 18, 2025
@sitole sitole force-pushed the template-build-image-url-mask branch from f56eee6 to ac03cab Compare July 18, 2025 12:46
@sitole
Copy link
Member Author

sitole commented Jul 18, 2025

After discussion with @jakubno we decided that using CLI attribute can be confusing for customers that don't need this image to be used, and can look like we are supporting custom docker repositories for our primary e2b cloud.

There is a new ENV variable called E2B_IMAGE_URI_MASK that does the same work as the previous CLI param.

@sitole sitole merged commit 56dfb42 into main Jul 18, 2025
6 checks passed
@sitole sitole deleted the template-build-image-url-mask branch July 18, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants