Client ID part removal from SDKs #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sitole
commented
Jul 17, 2025
sitole
commented
- CLI spawn, connect, and logs work with and without the client part provided
- JavaScript and Python SDKs are no longer returning IDs with client part
🦋 Changeset detectedLatest commit: 4e1c6f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The following task will be to bump cli version and release it. |
sitole
requested review from
jakubno,
ValentaTomas and
mishushakov
as code owners
|
The SDK changes look good to me, but we also have to remove this from the CLI |
mishushakov
approved these changes
Jul 17, 2025
Okay, done here. I thought there was a hardcoded JavaScript version dependency in the CLI, and we need to release sdk first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.