-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Nginx based session proxy with orchestrator proxy #417
base: main
Are you sure you want to change the base?
Conversation
de6b900
to
3f945bd
Compare
Right now (for the deployment) we will have both proxies running at the same time? |
Yea, both are running but for traffic new one is used. Actually it's just change of the port in client-proxy. Comes to my mind, if you think its somehow invasive we can for example route traffic to now one just for some teams / enable it with some feature flag to enable quick revert. Request proxy is done in context where we know about exact client so gives us big space. |
3f945bd
to
37893d3
Compare
90e639d
to
96c3425
Compare
Related to 96c3425 commit Reverts change that routed traffic to orchestrator proxy. After internal discussion we decided that we want to implement orchestrator proxy and then try to add feature-flags to enable it, but its dedicated to separated request. Just if you want to test changes its needed to revert this commit, without it traffic will float via session-proxy instead. |
bacbce6
to
a8bbdd6
Compare
a8bbdd6
to
05a5ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some problem with RPC after this change (I changed the port in client proxy). I can write / read files from sandbox (uses HTTP server). But I can't start command etc..
2366375
to
31163b7
Compare
31163b7
to
3330b9f
Compare
…nt nginx based session-proxy with new implementation there is error that envd returns "connection reset by peer" when there was support for keep alive tcp connections for re-use.
3330b9f
to
709dd69
Compare
With commit 3330b9f i fixed issue were envd randomly responds with I noticed current nginx session-proxy is missing I don't like idea to disabling it just because envd complains. Iam mostly concerned about how this can affect traffic. Sure, I will continue with finding some relevant docs about golang http.server and handling idle connections. |
Implements http proxy in orchestrator that replaces current nginx-based session proxy that is using dns server from orchestrator to route traffic.
5007
allowing smooth deployment