-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move build state away from api - integration tests #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng no longer used
- build cache holding latest builds logs before ttl expires - template creation grcp endpoint no longer streams logs - build logic and async execution separated to own service
jakubno
commented
Mar 14, 2025
@@ -14,10 +14,13 @@ const ( | |||
var ( | |||
APIServerURL = utils.RequiredEnv("TESTS_API_SERVER_URL", "e.g. https://api.great-innovations.dev") | |||
SandboxTemplateID = utils.RequiredEnv("TESTS_SANDBOX_TEMPLATE_ID", "e.g. base") | |||
BuildIDToBeBuild = utils.RequiredEnv("TESTS_SANDBOX_BUILD_ID_TO_BE_BUILD", "e.g. base") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
BuildIDToBeBuild = utils.RequiredEnv("TESTS_SANDBOX_BUILD_ID_TO_BE_BUILD", "e.g. base") | |
BuildIDToBeBuild = utils.RequiredEnv("TESTS_SANDBOX_BUILD_ID_TO_BE_BUILD", "prepared env build in status waiting") |
f826a0e
to
82d2b0b
Compare
2afda5b
to
f0232d1
Compare
Base automatically changed from
move-build-state-away-from-api-e2b-1661
to
main
March 17, 2025 13:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] - Revert changes in test trigger