Add sqlc setup #455
Draft
Add sqlc setup #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubno
added
improvement
| conn *pgxpool.Pool | ||
| } | ||
|
|
||
| var databaseURL = os.Getenv("POSTGRES_CONNECTION_STRING") |
There was a problem hiding this comment.
Wouldn't it make sense to load the env vars here via the utils.RequiredEnv?
| // Parse the connection pool configuration | ||
| config, err := pgxpool.ParseConfig(databaseURL) | ||
| if err != nil { | ||
| log.Fatalf("Unable to parse database URL: %v", err) |
There was a problem hiding this comment.
Does it make sense to do log.Fatal here that does os.Exit vs returning error so we can handle that (also by quitting probably).
| // Create the connection pool | ||
| pool, err := pgxpool.NewWithConfig(ctx, config) | ||
| if err != nil { | ||
| log.Fatalf("Unable to create connection pool: %v", err) |
There was a problem hiding this comment.
Same as the comment above about returning error.
| @@ -0,0 +1,3 @@ | |||
| -- name: Example :one | |||
| SELECT * | |||
There was a problem hiding this comment.
Is the example here intentional?
| if err != nil { | ||
| log.Fatalf("Unable to create connection pool: %v", err) | ||
| } | ||
| defer pool.Close() |
There was a problem hiding this comment.
Why is the pool closed on defer, before we return the client?
|
It isn't ready yet, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minimal configuration for sqlc, the idea is to start minimal and progressively convert to sqlc.
This way we will have time to properly evaluate without huge investment on refactoring whole codebase. Also the style we want to use it will probably evolve.
Also started separating
sharedanddbpackages