Modified: controller / models / chiller.py #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code modifications in lines: 158, 198, 246
Issue 1:
Calculating parameter h_is raises an error in the original version because the argument s_suc is transformed into an array (np.array([s_suc])). This is not necessary as s_suc is already an array.
Issue 2:
Parameter plr in the results tuple can be either a scalar or an array, depending on the values of other parameters, so the form will depend on the system setup. In cases where plr is a scalar, the program will raise an error because other elements are arrays.
The proposed patch: the calculated plr is checked. If it is not an array, it is transoformed into an array plr_a, which is used in the results tuple. For other calculations plr is used.