Skip to content

Modified: controller / models / chiller.py #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

markokfs
Copy link

@markokfs markokfs commented May 15, 2025

Code modifications in lines: 158, 198, 246

Issue 1:
Calculating parameter h_is raises an error in the original version because the argument s_suc is transformed into an array (np.array([s_suc])). This is not necessary as s_suc is already an array.

Issue 2:
Parameter plr in the results tuple can be either a scalar or an array, depending on the values of other parameters, so the form will depend on the system setup. In cases where plr is a scalar, the program will raise an error because other elements are arrays.

The proposed patch: the calculated plr is checked. If it is not an array, it is transoformed into an array plr_a, which is used in the results tuple. For other calculations plr is used.

markokfs and others added 3 commits May 15, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants