Sync with zarr python 3 beta 2 #388
Conversation
| @@ -626,35 +603,40 @@ def supports_listing(self) -> bool: | |||
| def supports_deletes(self) -> bool: | |||
| return self._store.supports_deletes | |||
|
|
|||
| def list(self) -> AsyncGenerator[str, None]: | |||
There was a problem hiding this comment.
The change from async generator to async iterator doesnt change anything on the rust side, its the same prototype
| @@ -444,10 +420,6 @@ def async_ancestry(self) -> AsyncGenerator[SnapshotMetadata, None]: | |||
| """ | |||
| return self._store.async_ancestry() | |||
|
|
|||
| async def empty(self) -> bool: | |||
| """Check if the store is empty.""" | |||
| return await self._store.empty() | |||
There was a problem hiding this comment.
what happened here? did this disappear from the abc?
There was a problem hiding this comment.
There was a problem hiding this comment.
If the types are the same, I'd keep it, this is probably a much faster impl
There was a problem hiding this comment.
Its not the same, takes prefix now. gunna take a stab at it
There was a problem hiding this comment.
I added a simple implmenetation that just uses the rust list_dir function. I think that is right, but there is probably a more optimized way to do it?
There was a problem hiding this comment.
This is great, it will get fast once we make list_dir fast. Thank you
| @@ -735,7 +740,14 @@ impl Store { | |||
| Key::Chunk { node_path, coords } => { | |||
| let mut guard = self.repository.write().await; | |||
| let repository = guard.deref_mut(); | |||
| Ok(repository.set_chunk_ref(node_path, coords, None).await?) | |||
* main: Sync with zarr python 3 beta 2 (#388)
Closes #387
This relies on a lot of the default functions from zarr's
Storeso it can most likely be further optimized in the future.