Merge pull request #7 from earthpyy/eliminate-dup

Eliminate duplication on dropdown items

dropdown/helpers.py

@@ -74,13 +74,13 @@ def from_model(
         count = len(result_list)
 
     # results
-    return [
+    return utils.remove_duplication(
         types.DropdownItem(
             label=operator.attrgetter(label_field)(x) if label_field is not None else str(x),
             value=operator.attrgetter(value_field)(x),
             context={y: operator.attrgetter(y)(x) for y in (context_fields)},
         ) for x in result_list
-    ], count
+    ), count
 
 
 def from_choices(choices: models.Choices) -> typing.Tuple[typing.List[types.DropdownItem], int]:
@@ -90,4 +90,4 @@ def from_choices(choices: models.Choices) -> typing.Tuple[typing.List[types.Drop
     @param choices: choices to get dropdown
     """
 
-    return [types.DropdownItem(label=x.label, value=x.value) for x in sorted(choices, key=lambda x: x.label)]
+    return utils.remove_duplication(types.DropdownItem(label=x.label, value=x.value) for x in sorted(choices, key=lambda x: x.label))

dropdown/types.py

@@ -8,3 +8,9 @@ def __init__(self, value: typing.Optional[typing.Any], label: str = None, contex
         self.value = value
         self.label = label or str(value or '')
         self.context = context or {}
+
+    def __eq__(self, o: object) -> bool:
+        return self.value == o.value and self.label == o.label and self.context == self.context
+
+    def __hash__(self) -> int:
+        return hash((self.value, self.label, self.context))

dropdown/utils.py

@@ -1,2 +1,10 @@
+import collections
+import typing
+
+
 def dot_to_relation(value: str) -> str:
     return value.replace('.', '__')
+
+
+def remove_duplication(value: typing.Iterable) -> list:
+    return list(collections.OrderedDict.fromkeys(value))