Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CRAN submission #678

Merged
merged 19 commits into from
Oct 17, 2024
Merged

Prepare CRAN submission #678

merged 19 commits into from
Oct 17, 2024

Conversation

strengejacke
Copy link
Member

No description provided.

@strengejacke
Copy link
Member Author

Hey @DominiqueMakowski, still active on GitHub? 😎
Once datawizard is accepted on CRAN, we need to submit bayestestR next, as a prerequisite for parameters (which has a deadline until 25th Oct).
All checks here pass, maybe we submit to win-builder (need datawizard to be built on windows), and then use this PR for CRAN submission (at some time next week).

@DominiqueMakowski
Copy link
Member

@strengejacke
Copy link
Member Author

Checks on old-rel look good. Maybe we wait until datawizard 0.13.0 is available for win-devel, check on that version with win-builder, and then submit?

@strengejacke
Copy link
Member Author

Were checks on R-release also ok? R-devel still not available for datawizard win-builder...

@DominiqueMakowski
Copy link
Member

@strengejacke
Copy link
Member Author

ok, thanks. So we either wait for devel-version of datawizard to be built, or you just submit bayestestR, using this PR (and we don't test on win-builder R-devel). I think it's not necessary, because everything should be fine. What do you think?

@DominiqueMakowski
Copy link
Member

Didn't pass because of 1 note erf

@strengejacke
Copy link
Member Author

bayesfactor 10.14 0.94 11.13

This is annoying, sometimes, these example run under 10 secs, sometimes take much longer, and we didn't change anything... :-/
Let me fix that example.

@strengejacke
Copy link
Member Author

ok, I just put parts of the examples into dontrun{}, if that's ok for you.

@strengejacke
Copy link
Member Author

Have you re-submitted already?

@strengejacke
Copy link
Member Author

Any updates on the state of submission?

@DominiqueMakowski
Copy link
Member

DominiqueMakowski commented Oct 15, 2024

Came back with the same NOTE

* checking examples ... [36s] NOTE
Examples with CPU (user + system) or elapsed time > 10s
             user system elapsed
bayesfactor 10.47   0.84   11.35

@strengejacke
Copy link
Member Author

Hm, I thought replacing donttest with dontrun is sufficient?

@strengejacke
Copy link
Member Author

Have you pulled the latest commits from this PR? There's only this example left running:

library(bayestestR)

prior <- distribution_normal(1000, mean = 0, sd = 1)
posterior <- distribution_normal(1000, mean = 0.5, sd = 0.3)

bayesfactor(posterior, prior = prior, verbose = FALSE)

which takes some milliseconds. All remaining examples are now ## Not run:.

@strengejacke
Copy link
Member Author

Ok, let's put everything in dontrun(), then there can't be any time left for computation. Can you pull the latest commit and try to re-submit? Very strange...

@DominiqueMakowski
Copy link
Member

https://win-builder.r-project.org/incoming_pretest/bayestestR_0.15.0_20241015_120908/Windows/00check.log same note, could you try submittting yourself and I'll validate?

@strengejacke
Copy link
Member Author

That's pretty strange... I can try submitting.

@strengejacke
Copy link
Member Author

ok, submitted. You just need to confirm the submission. If this still doesn't pass, we should write the CRAN team.

@DominiqueMakowski
Copy link
Member

submitted

@strengejacke
Copy link
Member Author

🤞

@strengejacke
Copy link
Member Author

Ok, seems like initial checks have passed and there's something else we need to respond to?

@strengejacke strengejacke merged commit 080f664 into main Oct 17, 2024
20 of 22 checks passed
@strengejacke strengejacke deleted the rc_0_15_0 branch October 17, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants