-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CRAN submission #678
Conversation
Hey @DominiqueMakowski, still active on GitHub? 😎 |
Checks on old-rel look good. Maybe we wait until datawizard 0.13.0 is available for win-devel, check on that version with win-builder, and then submit? |
Were checks on R-release also ok? R-devel still not available for datawizard win-builder... |
ok, thanks. So we either wait for devel-version of datawizard to be built, or you just submit bayestestR, using this PR (and we don't test on win-builder R-devel). I think it's not necessary, because everything should be fine. What do you think? |
Didn't pass because of 1 note erf |
This is annoying, sometimes, these example run under 10 secs, sometimes take much longer, and we didn't change anything... :-/ |
ok, I just put parts of the examples into |
Have you re-submitted already? |
Any updates on the state of submission? |
Came back with the same NOTE
|
Hm, I thought replacing donttest with dontrun is sufficient? |
Have you pulled the latest commits from this PR? There's only this example left running: library(bayestestR)
prior <- distribution_normal(1000, mean = 0, sd = 1)
posterior <- distribution_normal(1000, mean = 0.5, sd = 0.3)
bayesfactor(posterior, prior = prior, verbose = FALSE) which takes some milliseconds. All remaining examples are now |
Ok, let's put everything in |
https://win-builder.r-project.org/incoming_pretest/bayestestR_0.15.0_20241015_120908/Windows/00check.log same note, could you try submittting yourself and I'll validate? |
That's pretty strange... I can try submitting. |
ok, submitted. You just need to confirm the submission. If this still doesn't pass, we should write the CRAN team. |
submitted |
🤞 |
Ok, seems like initial checks have passed and there's something else we need to respond to? |
No description provided.