Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlation matrices now zap small by default #336

Merged
merged 13 commits into from
Jan 4, 2025
Merged

Correlation matrices now zap small by default #336

merged 13 commits into from
Jan 4, 2025

Conversation

DominiqueMakowski
Copy link
Member

r <- data.frame(
  x = rnorm(10000),
  y = rnorm(10000),
  z = rnorm(10000)
) |> 
  correlation::correlation() 

summary(r)
#> # Correlation Matrix (pearson-method)
#> 
#> Parameter |    z |    y
#> -----------------------
#> x         | 0.01 | 0.02
#> y         | 0.00 |     
#> 
#> p-value adjustment method: Holm (1979)
summary(r, zap_small=F)
#> # Correlation Matrix (pearson-method)
#> 
#> Parameter |         z |    y
#> ----------------------------
#> x         |      0.01 | 0.02
#> y         | -7.98e-04 |     
#> 
#> p-value adjustment method: Holm (1979)

Created on 2025-01-03 with reprex v2.1.1

@strengejacke
Copy link
Member

strengejacke commented Jan 3, 2025

Why is the default value for zap_small NULL and not TRUE?

@strengejacke
Copy link
Member

Ok, doesn't work when it defaults to TRUE.

@strengejacke strengejacke merged commit 94f3d0a into main Jan 4, 2025
20 of 22 checks passed
@strengejacke strengejacke deleted the zap_small branch January 4, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants