Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 16, 2025

Description

The verbose argument was not being passed to insight::get_parameters() calls, causing unwanted warnings to propagate to downstream packages like {statsExpressions}.

Proposed Changes

Added verbose = verbose parameter to all insight::get_parameters() calls within functions that accept a verbose argument:

  • .effectsize_contingencyTableBF() - line 99
  • .effectsize_correlationBF() - line 172
  • .effectsize_proportionBF() - line 185
  • .data_from_formula() - line 42

This ensures warnings are properly suppressed when users set verbose = FALSE.

Original prompt

This section details on the original issue you should resolve

<issue_title>Consistently passing verbose to the underlying method</issue_title>
<issue_description>This is just one example, but I think there are a few others in the codebase:

.effectsize_correlationBF <- function(model, type = NULL, verbose = TRUE) {
rho <- insight::get_parameters(model)[["rho"]]

Here, verbose argument should be passed to insight::get_parameters(), but it isn't.

This discrepancy is leading to some unnecessary warning messages bubbling up in downstream packages, like {statsExpressions}.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 16, 2025
Copilot AI changed the title [WIP] Fix passing verbose to underlying method Pass verbose argument to insight::get_parameters() calls Nov 16, 2025
Copilot finished work on behalf of IndrajeetPatil November 16, 2025 15:03
Copilot AI requested a review from IndrajeetPatil November 16, 2025 15:03
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review November 16, 2025 15:34
@IndrajeetPatil
Copy link
Member

Failing workflows unrelated to the changes in the current PR. So ignoring them before merging.

@IndrajeetPatil IndrajeetPatil merged commit b69281c into main Nov 16, 2025
22 of 27 checks passed
@IndrajeetPatil IndrajeetPatil deleted the copilot/fix-verbose-argument-passing branch November 16, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistently passing verbose to the underlying method

2 participants