Skip to content

Allow dpars-argument to be passed to predict-function #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2025
Merged

Conversation

strengejacke
Copy link
Member

if user provided dpars argument, we just pass it to the predict()-function. we don't overwrite the predict argument, because this allows us to pass dpars to posterior_predict() - else, when dpars are provided via the predict-argument, we always set predict = "expectation", thus, have no option to use dpars with posterior_predictions().

Copy link

codecov bot commented Apr 19, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.95%. Comparing base (ad16942) to head (79e0fa8).
Report is 324 commits behind head on main.

Files with missing lines Patch % Lines
R/get_predicted_args.R 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   55.75%   59.95%   +4.19%     
==========================================
  Files         125      129       +4     
  Lines       15514    17192    +1678     
==========================================
+ Hits         8650    10307    +1657     
- Misses       6864     6885      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@strengejacke strengejacke merged commit 1dd0f88 into main Apr 19, 2025
21 of 25 checks passed
@strengejacke strengejacke deleted the dpar_as_dots branch April 19, 2025 12:07
@strengejacke
Copy link
Member Author

@DominiqueMakowski can you install the latest main from GitHub and check if all your edge cases work as expected?

@DominiqueMakowski
Copy link
Member

It should work by default as previously right? So what is the feature allowed by this changed?

@strengejacke
Copy link
Member Author

Yes, it's only an addition. We can now also pass the dpar argument and use predict = "prediction".

@strengejacke
Copy link
Member Author

Like get_predicted(dpar="mu", predict="prediction"). Previously, when predict="mu" or any other dpar, predict was always set to "expectation", and if you passed dpar directly, this did no longer work.

@DominiqueMakowski
Copy link
Member

yes that makes sense, I'll test it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants