Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace datawizard::data_rename #474

Merged
merged 3 commits into from
Dec 12, 2024
Merged

replace datawizard::data_rename #474

merged 3 commits into from
Dec 12, 2024

Conversation

rempsyc
Copy link
Member

@rempsyc rempsyc commented Dec 12, 2024

@rempsyc rempsyc requested review from strengejacke and removed request for strengejacke December 12, 2024 23:33
@rempsyc
Copy link
Member Author

rempsyc commented Dec 12, 2024

Mmmm I just thought that relying on gsub might create a problem if the column names already contain dots, maybe we have to take a step back

@rempsyc rempsyc changed the title replace datawizard::data_unite and datawizard::data_rename with gsub and setNames replace datawizard::data_rename with gsub and setNames Dec 12, 2024
@rempsyc rempsyc changed the title replace datawizard::data_rename with gsub and setNames replace datawizard::data_rename Dec 12, 2024
@rempsyc rempsyc merged commit 1ee2f80 into main Dec 12, 2024
21 of 22 checks passed
@rempsyc rempsyc deleted the datawizard branch December 12, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rempsyc