Close connections asyncronously #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
commented
Apr 14, 2025
ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnection.java
Show resolved
Hide resolved
ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnection.java
Show resolved
Hide resolved
ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java
Show resolved
Hide resolved
This was referenced Apr 14, 2025
rbygrave
reviewed
Apr 24, 2025
ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java
Show resolved
Hide resolved
ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java
Show resolved
Hide resolved
ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java
Show resolved
Hide resolved
ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java
Show resolved
Hide resolved
ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnection.java
Show resolved
Hide resolved
ebean-datasource/src/test/java/io/ebean/datasource/test/NetworkOutageTest.java
Show resolved
Hide resolved
ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java
Show resolved
Hide resolved
rbygrave
changed the title
|
Augmented this PR with - #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing a connection may block (see #126)
this PR introduces a backgroundexecutor, which performs the (relative long running) close tasks in a separate thread, so that they are not blocking the pool