Copy properties instead of setting as default value #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you define
and use the Map interface, e.g.
props.keySet()
will return exactlyuser
andpassword
Only a direct access with
property.getValue("someVal")
will fall through toconnectionProps
Unfortunately some drivers like H2 and also MariaDB use the Map interface of Properties, which does not expose the underlying default values.
I noticed this, as some custom connection properties were not correctly applied to the driver.
So the use of
Properties(defaults)
can be a trap.This PR changes all places to copy the defaults to the new object.
@rbygrave this is IMHO a low hanging fruit ;)