Internal heartbeat Timer, use Virtual Thread for Java 21#135
Internal heartbeat Timer, use Virtual Thread for Java 21#135
Conversation
Using Multi-Version jar, use Virtual Thread instead of Timer for executing the heartbeat test
rPraml
left a comment
There was a problem hiding this comment.
I like that.
I have one question, though: The Maven build now requires Java 21. How can we test against Java 17?
| @@ -1,11 +1,61 @@ | |||
| package io.ebean.datasource.pool; | |||
|
|
|||
| import io.ebean.datasource.pool.ConnectionPool.Heartbeat; | |||
There was a problem hiding this comment.
Cool: I didn't know this method until now:
Rolands note: Classes will be located in META-INF/versions/21
https://docs.oracle.com/javase/10/docs/specs/jar/jar.html#multi-release-jar-files
Technically it BUILDs needing the Java 21 compiler ... the surefire tests run using the classes from What I need to do is add another test module in order to test the Java 21 code. |
|
Testing java 11 executorFactory with java 21 would be OK for me |
Using Multi-Version jar, use Virtual Thread instead of Timer for executing the heartbeat test