Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scanpy tools to scanpy 1.9.3 #313

Merged
merged 20 commits into from
Feb 27, 2024
Merged

Move scanpy tools to scanpy 1.9.3 #313

merged 20 commits into from
Feb 27, 2024

Conversation

pcm32
Copy link
Member

@pcm32 pcm32 commented Feb 11, 2024

Description

This PR aims to move scanpy tools to scanpy 1.9.3.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have made any required changes to upstream dependencies for a tool wrapper, and they are available in distribution channels (e.g. Pip, Conda).
  • If I have updated the underlying software for a tool wrapper (e.g. scanpy-scripts by changing the value of @TOOL_VERSION@), then I have reset all 'build' values to 0 (e.g. @TOOL_VERSION@+galaxy0)
  • If I have updated a tool wrapper without a software change, then I have bumped the associated 'build' values (e.g. @TOOL_VERSION@+galaxy0 @TOOL_VERSION@+galaxy1). It is acceptable to do this as well when the cli version changed but not the underlying tool (to avoid issues in the coming point).
  • If I changed the version, the @TOOL_VERSION@ part of the version does not contain any + symbols within, otherwise this will break tool ordering on the interface and the default tool being picked. Tool version should always conform to PEP440 to avoid this issue. The only + should be the one preceding galaxy<build> (unless that all the versions from that tool previously followed a different pattern).

@pcm32
Copy link
Member Author

pcm32 commented Feb 11, 2024

Current failures to be fixed are available on the report file attached.
test_report.html.zip

Most of them tend to be different file sizes. I would suggest that we change file comparisons with hdf5 paths checks according to the operation executed, which will avoid this issue in the future (see some of the tests in the anndata_operations tools).

@pcm32
Copy link
Member Author

pcm32 commented Feb 11, 2024

I have fixed now the older use of anndata.read in the base package

/usr/local/lib/python3.9/site-packages/anndata/__init__.py:51: FutureWarning: `anndata.read` is deprecated, use `anndata.read_h5ad` instead. `ad.read` will be removed in mid 2024.

ebi-gene-expression-group/scanpy-scripts#128

@pcm32
Copy link
Member Author

pcm32 commented Feb 11, 2024

Made some progress @anilthanki but still 25/44 to go.

@pcm32
Copy link
Member Author

pcm32 commented Feb 16, 2024

This is great, thanks for dealing with all the tests! I guess this means that we can do now a release of scanpy scripts at the other side.

(I mean before merging this)

@pcm32 pcm32 changed the title Move scanpy tools to scanpy 1.9.x Move scanpy tools to scanpy 1.9.3 Feb 21, 2024
@pcm32 pcm32 requested review from pmb59 and irisdianauy February 21, 2024 22:30
Copy link
Member

@pmb59 pmb59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM @pcm32 @anilthanki

@pcm32 pcm32 merged commit ee197a8 into develop Feb 27, 2024
7 checks passed
@pcm32
Copy link
Member Author

pcm32 commented Feb 27, 2024

Thanks for the review @pmb59 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants