-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scanpy tools to scanpy 1.9.3 #313
Conversation
Current failures to be fixed are available on the report file attached. Most of them tend to be different file sizes. I would suggest that we change file comparisons with hdf5 paths checks according to the operation executed, which will avoid this issue in the future (see some of the tests in the anndata_operations tools). |
I have fixed now the older use of anndata.read in the base package
|
Made some progress @anilthanki but still 25/44 to go. |
This is great, thanks for dealing with all the tests! I guess this means that we can do now a release of scanpy scripts at the other side. (I mean before merging this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM @pcm32 @anilthanki
Thanks for the review @pmb59 ! |
Description
This PR aims to move scanpy tools to scanpy 1.9.3.
Fixes # (issue)
Type of change
Checklist
@TOOL_VERSION@
), then I have reset all 'build' values to 0 (e.g.@TOOL_VERSION@+galaxy0
)@TOOL_VERSION@+galaxy0
@TOOL_VERSION@+galaxy1
). It is acceptable to do this as well when the cli version changed but not the underlying tool (to avoid issues in the coming point).@TOOL_VERSION@
part of the version does not contain any+
symbols within, otherwise this will break tool ordering on the interface and the default tool being picked. Tool version should always conform to PEP440 to avoid this issue. The only+
should be the one precedinggalaxy<build>
(unless that all the versions from that tool previously followed a different pattern).