-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters to Scmap #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hexhowells I think that this is now ready to merge, with your contributions. If you could take a brief look, I can merge and then you should be able to use in your tutorial and publish it. If there any other tool that was missing changes to be merged? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines additional parameters in Scmap Cell Projection that were included recently here: ebi-gene-expression-group/scmap-cli#17 - based on #310 to be able to add to the external branch.
Fixes # (issue)
Type of change
Checklist
@TOOL_VERSION@
), then I have reset all 'build' values to 0 (e.g.@TOOL_VERSION@+galaxy0
)@TOOL_VERSION@+galaxy0
@TOOL_VERSION@+galaxy1
). It is acceptable to do this as well when the cli version changed but not the underlying tool (to avoid issues in the coming point).@TOOL_VERSION@
part of the version does not contain any+
symbols within, otherwise this will break tool ordering on the interface and the default tool being picked. Tool version should always conform to PEP440 to avoid this issue. The only+
should be the one precedinggalaxy<build>
(unless that all the versions from that tool previously followed a different pattern).