Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to Scmap #318

Merged
merged 16 commits into from
Apr 23, 2024
Merged

Add parameters to Scmap #318

merged 16 commits into from
Apr 23, 2024

Conversation

pcm32
Copy link
Member

@pcm32 pcm32 commented Apr 19, 2024

Description

Defines additional parameters in Scmap Cell Projection that were included recently here: ebi-gene-expression-group/scmap-cli#17 - based on #310 to be able to add to the external branch.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have made any required changes to upstream dependencies for a tool wrapper, and they are available in distribution channels (e.g. Pip, Conda).
  • If I have updated the underlying software for a tool wrapper (e.g. scanpy-scripts by changing the value of @TOOL_VERSION@), then I have reset all 'build' values to 0 (e.g. @TOOL_VERSION@+galaxy0)
  • If I have updated a tool wrapper without a software change, then I have bumped the associated 'build' values (e.g. @TOOL_VERSION@+galaxy0 @TOOL_VERSION@+galaxy1). It is acceptable to do this as well when the cli version changed but not the underlying tool (to avoid issues in the coming point).
  • If I changed the version, the @TOOL_VERSION@ part of the version does not contain any + symbols within, otherwise this will break tool ordering on the interface and the default tool being picked. Tool version should always conform to PEP440 to avoid this issue. The only + should be the one preceding galaxy<build> (unless that all the versions from that tool previously followed a different pattern).

@pcm32 pcm32 changed the title Hexhowells scmap dev Add parameters to Scmap Apr 22, 2024
@pcm32
Copy link
Member Author

pcm32 commented Apr 22, 2024

@hexhowells I think that this is now ready to merge, with your contributions. If you could take a brief look, I can merge and then you should be able to use in your tutorial and publish it. If there any other tool that was missing changes to be merged?

@pcm32 pcm32 merged commit 8350493 into develop Apr 23, 2024
7 checks passed
@pcm32 pcm32 mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants