Conversation
anttimaki
force-pushed
the
splash-speedrun-pt2
branch
from
4424be2 to
e51b589
Compare
anttimaki
force-pushed
the
splash-speedrun
branch
from
0ce7372 to
53f2fc7
Compare
| import UtilityMixin from './mixins/UtilityMixin.vue'; | ||
| import ManagerInformation from '../_managerinf/ManagerInformation'; | ||
|
|
||
| @Component({}) |
There was a problem hiding this comment.
Minor nit: I don't believe we need the {}
There was a problem hiding this comment.
One argument (options) is required.
| import UtilityMixin from './mixins/UtilityMixin.vue'; | ||
| import ManagerInformation from '../_managerinf/ManagerInformation'; | ||
|
|
||
| @Component({}) |
There was a problem hiding this comment.
It could be worth moving to the Vue 3 Composition API - I won't make it a blocker but it's something to consider
There was a problem hiding this comment.
The last time I looked into Composition API I couldn't figure out how to use Vuex store in the new components, and I still don't. So I'd rather not get sidetracked with it now. Unless you have some pointers on how to get it working easily?
| </span> | ||
| <span v-else-if="updateError"> | ||
| Error updating the mod list: {{ updateError }}<br /> | ||
| {{ appName }} will keep trying to update the mod list in the background. |
There was a problem hiding this comment.
Nit: We could generify this by using The manager or We
To counter the design a little, we could have:
There was an error updating the mod list. <a>Show the error</a>.
{{ appName }} will keep trying to update the mod list in the background.
The thinking is that the a tag would open a modal and we can keep the normal error preview.
There was a problem hiding this comment.
Changed to The manager.
I can do another PR for the error modal suggestion, but do you think it still matters what we do here if the profile import modal (in #1598 ) will show the error "inline" like here? I'd rather not use the error modal there, as that would interfere with the progress made on import modal.
| {{ appName }} will keep trying to update the mod list in the background. | ||
| </span> | ||
| <span v-else> | ||
| It seems like the latest mod list hasn't been loaded from Thunderstore yet. |
There was a problem hiding this comment.
I'd refrain from uncertainty because we know what occurred to get into this state.
We can just say something like:
An error occurred when updating the mod list. Would you like to <a>try again?</a>
There was a problem hiding this comment.
Changed the texts along the lines of the suggestion.
The banner will show on top of an empty online mod list, explaining that the list is empty because splash screen failed to load it. A one-click option for trying to update the mod list is offered. This change is adjustment to the fact that the splash screen no longer stops on errors and user is more likely to reach the manager view with no mod list loaded into Vuex.
anttimaki
force-pushed
the
splash-speedrun
branch
from
53f2fc7 to
c24188a
Compare
anttimaki
force-pushed
the
splash-speedrun-pt2
branch
from
e51b589 to
ebd0ced
Compare
2 participants
The banner will show on top of an empty online mod list, explaining that the list is empty because splash screen failed to load it. A one-click option for trying to update the mod list is offered.
This change is adjustment to the fact that the splash screen no longer stops on errors and user is more likely to reach the manager view with no mod list loaded into Vuex.