Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Added yarn v4 support #1250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Added yarn v4 support #1250

wants to merge 1 commit into from

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 6, 2024

What does this PR do?

Added yarn v4 support.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

It needs for https://issues.redhat.com/browse/CRW-7573

Is it tested? How?

Release Notes

Docs PR

@olexii4 olexii4 requested a review from SDawley November 6, 2024 15:16
@olexii4 olexii4 marked this pull request as ready for review November 6, 2024 15:18
@olexii4 olexii4 changed the title fix: babel plugins versions fix: upgrade yarn.lock Nov 7, 2024
@olexii4 olexii4 force-pushed the CRW-7573 branch 5 times, most recently from b8c2c2f to b461d98 Compare November 8, 2024 16:52
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from che-bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from codecov bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@olexii4 olexii4 changed the title fix: upgrade yarn.lock [DO NOT MERGE] Added yarn v4 support Nov 8, 2024
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Nov 8, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 8, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (e0f9f74) to head (bcc0a32).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
+ Coverage   91.80%   91.85%   +0.04%     
==========================================
  Files         499      499              
  Lines       45657    45656       -1     
  Branches     3178     3172       -6     
==========================================
+ Hits        41917    41937      +20     
+ Misses       3707     3686      -21     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants