-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce frontend bundle size #1285
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
+ Coverage 91.58% 91.69% +0.10%
==========================================
Files 498 498
Lines 45590 45527 -63
Branches 3171 3172 +1
==========================================
- Hits 41754 41746 -8
+ Misses 3803 3752 -51
+ Partials 33 29 -4 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]" |
2 similar comments
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]" |
Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1285 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1285", name: che-dashboard}]}}]" |
What does this PR do?
Reduced frontend bundle size by 14 percent of our size.
Screenshot/screencast of this PR
Before
After
What issues does this PR fix or reference?
fixes eclipse-che/che#23219