fix: create multiarch image manifest with tools compatible with lates… #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkuznyetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Click here to review and test in web IDE: |
…t buildx extension Signed-off-by: Mykhailo Kuznietsov <[email protected]>
mkuznyetsov
force-pushed
the
che-21954
branch
from
a6460db
to
8a7b1f0
Compare
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-734 |
|
discussed and rejected as not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t buildx extension
What does this PR do?
'docker manifest create' won't work with images build from latest buildx extension, because of provenance attestations.
the solution is to replace this command with 'build imagetools" util that can work with images built in such way
What issues does this PR fix or reference?
eclipse-che/che#21954
Is it tested? How?
tested on forked repo action
Release Notes
Docs PR