Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Added php 7.4 #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added php 7.4 #252

wants to merge 1 commit into from

Conversation

BhawaniSingh
Copy link

What does this PR do?

Added php 7.4

What issues does this PR fix or reference?

Symphony demo doesn't work with php 7.1

Previous behavior

(Remove this section if not relevant)

New behavior

(Explain the PR as it should appear in the release notes)

Please review Che's Contributing Guide for best practices.

Tests written?

No

Docs updated?

Please add a matching PR to the docs repo and link that PR to this issue. Both will be merged at the same time.

Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BhawaniSingh You'll need to sign the eclipse contributor agreement and sign your commit and then I can merge this PR and fix the sample!

@BhawaniSingh
Copy link
Author

I tried to sign the ECA, but I'm facing issue,

Anonymous (BhawaniSingh@****.noreply) is not covered by the necessary legal agreements in order to proceed.

It was because my email set to private in github, even though I changed my mail to public, I'm still seeing this issue.
Can you help me out with this one?

@sparkoo
Copy link
Member

sparkoo commented Mar 2, 2020

@BhawaniSingh I think you have to sign the commit. You must have git config user.name and user.email set to same ones as you have registered on eclipse. Then do the commit with --signoff

https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Signing_off_on_a_commit

@JPinkney JPinkney mentioned this pull request Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants