Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java sample titles/paths in tests; fix Documentation test #22761

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Jan 11, 2024

What does this PR do?

  1. Fixes Java sample titles/paths in tests:
  • "Java 11 with Lombok" > "Java Lombok"
  • "Java 11 with Quarkus" > "Quarkus REST API"
  1. Removes test of unexisted "Devfile Documentation" link in Documentation E2E typescript test
  2. Fixes Documentation test which failed on step "Check if "About" dialog menu contains correct application version"

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

Run Dev Spaces 3.11.0 functional tests:

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Jan 11, 2024
Signed-off-by: Dmytro Nochevnov <[email protected]>
@dmytro-ndp dmytro-ndp requested review from SkorikSergey and removed request for nickboldt and ScrewTSW January 11, 2024 13:47
@dmytro-ndp dmytro-ndp merged commit 6728732 into main Jan 11, 2024
6 checks passed
@dmytro-ndp dmytro-ndp deleted the CRW-5398 branch January 11, 2024 15:05
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants