Stabilize workspace with parent test#23242
Merged
musienko-maxim merged 8 commits intomainfrom Nov 14, 2024
Merged
Conversation
e7dde4e to
b061ffa
Compare
SkorikSergey
approved these changes
Nov 13, 2024
Contributor
SkorikSergey
left a comment
There was a problem hiding this comment.
Approved. Setting security.workspace.trust.enabled: false` is much better than constantly fixing trustDialog errors.
artaleks9
approved these changes
Nov 13, 2024
dmytro-ndp
reviewed
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stabilize the WorkspaceWithParent and implement a new solution for disabling the TrustDialog using a new method. The main idea - is to switch it off in background mode with a special JS script using JavascriptExecutor and patching the local database in the browser session. It is similar to setting up its
"security.workspace.trust.enabled":falsewith user preferences. Handling the dialog by UI is hard because it is not easy to predict where it can appear.Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Run the WorkspaceWithParent.spec.ts as usual
-->
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.