Skip to content

Checklist of pull request approval by Eclipse Che QE team

Jump to bottom Edit New page
Ana Šemrov edited this page Mar 20, 2019 · 16 revisions
  1. Definition-Of-Done (DoD) is clear: feature specification / bug use case described and available for review.
  2. If DoD achievement verification requires creation of new E2E selenium tests or updating existed ones - they have to be created or updated.
  3. Code should has latest changes from the master branch before start E2E selenium tests.
  4. There are no changes in the code in pull request after E2E selenium tests execution was requested.
  5. Coverage of new or updated functionality by unit-tests >= 80%. We can use Cobertura maven plugin to measure coverage - next command generate Cobertura report: mvn cobertura:cobertura
  6. Build of whole project including unit and integration tests have passed successfully. It can be checked by command ci-build in comment of pull request, which run build on dedicated CI job.
  7. Execution of E2E selenium tests for Eclipse Che Multiuser on OCP (command ci-test in comment to the pull request to run selenium tests on dedicated CI job) shows no regression, that is success rate about 100%. Such execution doesn't include tests which fail because of known issue as well as "flaky" tests. To include that tests into execution as well locally, next parameters of E2E selenium tests launcher can be used:
  • --include-flaky-tests - to include flaky tests into execution;
  • --include-tests-under-repair - to include tests which failed constantly because of known issue.

  1. If pull request creator decides that changes influence assembly of Eclipse Che on Docker, E2E selenium tests should be executed against Eclipse Che on Docker as well - by using another the command ci-test-docker-single, which run build on another CI job.

  2. Actually, E2E selenium tests cover about 50% of functionality of Eclipse Che upstream. There is a list of features which are not covered by E2E selenium tests.

  3. There are some tests which require special configuration of product, or are executing to long, and so don't run by ci-test commands on Pull Requests:

Project Management

Community

Contributing

Clone this wiki locally