Macos rpath fix#2244
Open
artcore-c wants to merge 1 commit intoeclipse-cyclonedds:releases/0.10.xfrom
Open
Conversation
f43fc16 to
f3550c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds MacOS-specific
INSTALL_RPATHandBUILD_RPATHsettings for theidlcbinary to ensure dependent dynamic libraries such as:libiceoryx_posh.dyliblibiceoryx_binding_c.dyliblibiceoryx_hoofs.dylibcan be located at both build and runtime when used with
ros2_rollingandcolcon build.Key points:
idlcduring the CycloneDDS build processif(APPLE))MACOSX_RPATHis correctly setChecklist
releases/0.10.x)Testing
colcon build --symlink-installros2.reposmeta fileidlcexecutes without errors when invoked by CMakeRelated Issues