-
Notifications
You must be signed in to change notification settings - Fork 416
fix typos #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix typos #2250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"behaviour" and "serialisation" aren't so much typo's as English words, whereas "behavior" is mere dialect 🤣:
- "serialize | ˈsɪərɪəlʌɪz | (British English also serialise)"
- "behaviour | bɪˈheɪvjə | (behavior US English)"
I do agree there is an undesirable inconsistency in their use (the worst for "serialize"/"serialise"). If Cyclone today straddles the mid-Atlantic ridge and we want to prevent it from being torn apart by the continental drift, we need to choose a side. I would instinctively choose the old world, that goes without saying ...
(Also don't forget the pre-commit check is failing on the CI)
I will open an issue for this, more thorough, standardization for a future PR. We can pick which side of the Atlantic for this :) I will update the hashes as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually correct to delete?
Fixes a few minor typos during documentation review.