feature/chained pubsub #1798
Merged
feature/chained pubsub #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callback-sub1-pub2->sub2 chain (publishing inside a subscriber callback)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -232,3 +232,69 @@ TEST(core_cpp_pubsub, TestPublisherIsSubscribedTiming) | |||
| // finalize eCAL API | |||
| eCAL::Finalize(); | |||
| } | |||
|
|
|||
| TEST(core_cpp_pubsub, TestChainedPublisherSubscriberCallback) | |||
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(core_cpp_pubsub, TestChainedPublisherSubscriberCallback) | |
| TEST(core_cpp_pubsub /*unused*/, TestChainedPublisherSubscriberCallback /*unused*/) |
KerstinKeller
requested changes
Nov 19, 2024
comment out all logging (std::cout)
exit condition for TestChainedPublisherSubscriberCallback test added clang-tidy const correctness
| pub1_thread.join(); | ||
| int max_message_loops(100); | ||
| while ((subscriber2_received_count < message_count) && (max_message_loops-- > 0)) | ||
| { |
There was a problem hiding this comment.
Can you please explain the logic here?
There was a problem hiding this comment.
That loop will run approx. 1 second at maximum (or if all messages sent by by pub2 are received).
There was a problem hiding this comment.
Oh sorry, I see the problem. Fixed it.
KerstinKeller
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added pubsub unit test to test publishing inside a subscriber callback.