fix(ci): set version before tests, publishing #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
approved these changes
Aug 12, 2024
paullatzelsperger
added a commit
to paullatzelsperger/Technology-Gcp
that referenced
this pull request
Aug 12, 2024
* fix(ci): set version before tests, publishing * DEPENDENCIES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a temporary fix to update the
gradle/libs.version.tomlversion catalog before a version is published.Specifically, it passes the version string to
verify.yaml, so that tests are executed using the given upstream EDC modules, and it updatesgradle.properties,gradle/libs.versions.tomlandDEPENDENCIESbefore the Maven artefacts are published.In addition, the release job (
release-tech-aws.yaml) only bumps the version if it was a "release" version (not a hotfix/bugfix or a snapshot).Why it does that
employ a temporary fix until a restructuring of the release workflow can be implemented.
Further notes
I intentionally did not extract the
sedcommand in a re-usable action, because it is a temporary fix anyway, and it is better if it sticks out like a sore thumbLinked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.