Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1785 ConstField empty javadoc #1786

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Fix #1785 ConstField empty javadoc #1786

merged 6 commits into from
Feb 13, 2024

Conversation

patrodyne
Copy link
Contributor

This pull request resolves Issue #1785.

@patrodyne patrodyne mentioned this pull request Feb 12, 2024
Closed
@patrodyne patrodyne changed the title Fix ConstField empty javadoc Fix #1785 ConstField empty javadoc Feb 12, 2024
lukasj
lukasj reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the copyright year in changed files to say 2024 (instead of 2022, 2023), please? I also prefer if static imports are avoided.

Thank you.

lukasj
lukasj reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be also good to add a note to the changelog

@patrodyne
Copy link
Contributor Author

I've pushed commits:

lukasj
lukasj approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukasj lukasj merged commit 13402b7 into eclipse-ee4j:master Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrodyne @lukasj