Skip to content

[#606] test case missing type deserializer#608

Open
bmarwell wants to merge 1 commit intoeclipse-ee4j:2.xfrom
bmarwell:#606_record_typedeserializer
Open

[#606] test case missing type deserializer#608
bmarwell wants to merge 1 commit intoeclipse-ee4j:2.xfrom
bmarwell:#606_record_typedeserializer

Conversation

@bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Jul 17, 2023

[WIP] fixes #606

@bmarwell bmarwell force-pushed the #606_record_typedeserializer branch from 638896d to 68872e3 Compare July 17, 2023 07:39
}

@Test
public void record_with_type_deserializer() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underscores are rather untypical. Why not aligning with the camel case of the existing tests?

@mkarg
Copy link
Member

mkarg commented Dec 3, 2025

@m0mus Kindly asking for review.

@KyleAure
Copy link
Member

KyleAure commented Dec 8, 2025

@bmarwell @mkarg

I think this is a good test to have, but I think it needs to go into the main branch master instead of 2.x.
We will want to keep this for regression testing in the future.
If you could re-target this PR (or open a new one) that targets the main branch I will be happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants