Fix java.sql.Timestamp serialization#688
Open
g-tom wants to merge 2 commits intoeclipse-ee4j:masterfrom
Open
Conversation
g-tom
force-pushed
the
sql-timestamp-serialization
branch
from
bb0cfd3 to
71afad5
Compare
SqlTimestampSerializer missed to override toTemporalAccessor, leading to ClassCastExceptions in the default implementation in AbstractDateSerializer. Since it does all formatting after calling toInstant on the value, we can safely use the same code path as is used for java.util.Date (despite what is said about the inheritance relationship between Date and Timestamp in their API documentation). Closes eclipse-ee4j#687.
g-tom
force-pushed
the
sql-timestamp-serialization
branch
from
71afad5 to
0931470
Compare
bmarwell
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #687.