Open
Conversation
Signed-off-by: redmitry <redmitry@list.ru>
KyleAure
reviewed
Jan 21, 2026
|
|
||
| Jsonb jsonb = JsonbBuilder.create( | ||
| new JsonbConfig().withDeserializers(new Issue673.ReferenceableDeserializer())); | ||
| jsonb.fromJson(json, Issue673.LocationInterface.class); |
Member
There was a problem hiding this comment.
Suggested change
| jsonb.fromJson(json, Issue673.LocationInterface.class); | |
| LocationInterface result = jsonb.fromJson(json, Issue673.LocationInterface.class); | |
| assertNotNull(result); | |
| assertTrue(result instanceof Location); | |
| Location location = (Location) result; | |
| Referenceable refAble = location.getReference(); | |
| assertNotNull(refAble); | |
| assertFalse(refAble instanceof Reference); | |
| assertTrue(refAble instanceof IRIReference); | |
| IRIReference ref = (IRIReference) refAble; | |
| assertEquals("dummy reference", ref.getValue()); |
suggestion: this test just verifiers that no exception is thrown, ensure the correct object is returned.
src/test/java/org/eclipse/yasson/jsonstructure/JsonStructureToParserAdapterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: redmitry <redmitry@list.ru>
Author
|
Well although the response assertions are not about the tested case, more assertions wont hurt. |
Author
ACHTUNG! I just realized that I use Java 17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merged commits
Sorry since I merged several commits github closed previous pull request:
#674